Bug 1886702 - Fix util.load_yaml_or_json failures when loading json files#679
Open
serge-sans-paille wants to merge 1 commit intomozilla:mainfrom
Open
Bug 1886702 - Fix util.load_yaml_or_json failures when loading json files#679serge-sans-paille wants to merge 1 commit intomozilla:mainfrom
serge-sans-paille wants to merge 1 commit intomozilla:mainfrom
Conversation
serge-sans-paille
force-pushed
the
feature/improve-json-loader
branch
2 times, most recently
from
7c50793 to
754c978
Compare
badboy
changed the title
serge-sans-paille
force-pushed
the
feature/improve-json-loader
branch
2 times, most recently
from
10c0155 to
d91d0f4
Compare
Line number information are not available through the json API, but providing null line number is enough to make it compatible with other parts.
serge-sans-paille
force-pushed
the
feature/improve-json-loader
branch
from
d91d0f4 to
a8f7ee6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Line number information are not available through the json API, but providing null line number is enough to make it compatible with other parts.
Pull Request checklist
make testruns without emitting any warningsmake lintruns without emitting any errorsCHANGELOG.mdor an explanation of why it does not need one